diff --git a/dune/solvers/iterationsteps/projectedlinegsstep.cc b/dune/solvers/iterationsteps/projectedlinegsstep.cc index b852c1afdd17ac7fcb365aaccffffe7182be1ef2..2714f34b88e2adcd15c484022ba6228fdab7f538 100755 --- a/dune/solvers/iterationsteps/projectedlinegsstep.cc +++ b/dune/solvers/iterationsteps/projectedlinegsstep.cc @@ -145,7 +145,7 @@ solveLocalSystem(const Dune::BTDMatrix<typename MatrixType::block_type>& matrix, // Line search field_type alpha = (residual*linearCorrection) / correctionNormSquared; - alpha = std::max(std::min(alpha, lineSearchObs.upper(0)), lineSearchObs.lower(0)); + alpha = lineSearchObs[0].projectIn(alpha); if (isnan(alpha)) alpha = 1; diff --git a/dune/solvers/iterationsteps/trustregiongsstep.cc b/dune/solvers/iterationsteps/trustregiongsstep.cc index 914d80402bc3f573366de4495d958741057809a6..ef95d3cf0075a5e325f704e37143a2451f27194c 100644 --- a/dune/solvers/iterationsteps/trustregiongsstep.cc +++ b/dune/solvers/iterationsteps/trustregiongsstep.cc @@ -41,12 +41,7 @@ void TrustRegionGSStep<MatrixType, VectorType>::iterate() // 1d problem is convex x[i][j] = r / diag; - if ( x[i][j] < obstacles[i].lower(j)) { - x[i][j] = obstacles[i].lower(j); - } - else if ( x[i][j] > obstacles[i].upper(j)) { - x[i][j] = obstacles[i].upper(j); - } + x[i][j] = obstacles[i][j].projectIn(x[i][j]); } else { diff --git a/dune/solvers/solvers/trustregionsolver.cc b/dune/solvers/solvers/trustregionsolver.cc index 2feb30593812e6a80449af8c02e3d44f9819dae3..3f65815b8199387026fd6bf878e8f3e8f73123fb 100644 --- a/dune/solvers/solvers/trustregionsolver.cc +++ b/dune/solvers/solvers/trustregionsolver.cc @@ -23,10 +23,8 @@ void TrustRegionSolver<ProblemType,VectorType,MatrixType>::solve() // setup the trust-region in the maximums norm std::vector<BoxConstraint<field_type,blocksize> > trustRegionObstacles(x_.size()); for (size_t i=0; i<trustRegionObstacles.size(); i++) - for (int j=0; j<blocksize; j++) { - trustRegionObstacles[i].lower(j) = -initialRadius_; - trustRegionObstacles[i].upper(j) = initialRadius_; - } + for (int j=0; j<blocksize; j++) + trustRegionObstacles[i][j] = { -initialRadius_, initialRadius_ }; mgStep->obstacles_ = &trustRegionObstacles; diff --git a/dune/solvers/solvers/trustregionsolver.hh b/dune/solvers/solvers/trustregionsolver.hh index 9438b23ea2ad07aae79bfbdbbece0cd393817345..04aa5cb16cd0d5d3d243956cd97a829cbf0a5b15 100644 --- a/dune/solvers/solvers/trustregionsolver.hh +++ b/dune/solvers/solvers/trustregionsolver.hh @@ -108,10 +108,8 @@ protected: initialRadius_ *= scaling; for (size_t i=0; i<obs.size(); i++) - for (int j=0; j<blocksize; j++) { - obs[i].lower(j) = -initialRadius_; - obs[i].upper(j) = initialRadius_; - } + for (int j=0; j<blocksize; j++) + obs[i][j] = { -initialRadius_, initialRadius_ }; } /** \brief The problem type. */ diff --git a/dune/solvers/test/mmgtest.cc b/dune/solvers/test/mmgtest.cc index 5cb6525fb9e11b7e55a3f95ce11138e489e9e7fd..3b534924ff53ee8485871fa9358ffcad887e19a8 100644 --- a/dune/solvers/test/mmgtest.cc +++ b/dune/solvers/test/mmgtest.cc @@ -66,13 +66,8 @@ void solveObstacleProblemByMMGSolver(const GridType& grid, const MatrixType& mat std::vector<BoxConstraint<typename VectorType::field_type,blockSize> > boxConstraints(rhs.size()); for (size_t i = 0; i < boxConstraints.size(); ++i) - { for (int j = 0; j < blockSize; ++j) - { - boxConstraints[i].lower(j) = -1; - boxConstraints[i].upper(j) = +1; - } - } + boxConstraints[i][j] = { -1, +1 }; mmgStep.obstacles_ = &boxConstraints; // we need a vector of pointers to the transfer operator base class diff --git a/dune/solvers/test/obstacletnnmgtest.cc b/dune/solvers/test/obstacletnnmgtest.cc index 373c0da183af343c050e166814e52a7ff581800f..6321ca035355eec91a46d3e2710b2e057fc2ab37 100644 --- a/dune/solvers/test/obstacletnnmgtest.cc +++ b/dune/solvers/test/obstacletnnmgtest.cc @@ -66,13 +66,8 @@ void solveObstacleProblemByTNNMG(const GridType& grid, const MatrixType& mat, Ve // create double obstacle constraints BoxConstraintVector boxConstraints(rhs.size()); for (size_t i = 0; i < boxConstraints.size(); ++i) - { for (int j = 0; j < blockSize; ++j) - { - boxConstraints[i].lower(j) = -1; - boxConstraints[i].upper(j) = +1; - } - } + boxConstraints[i][j] = { -1, +1 }; // we want to control errors with respect to the energy norm induced by the matrix Norm norm(mat); diff --git a/dune/solvers/test/projectedgradienttest.cc b/dune/solvers/test/projectedgradienttest.cc index dcc7cdea6f9cd15a67d90ab1d9ae12981ae1d46a..df1fe3468f5a9a27c84c06b95a3965650dd78303 100644 --- a/dune/solvers/test/projectedgradienttest.cc +++ b/dune/solvers/test/projectedgradienttest.cc @@ -30,13 +30,11 @@ bool solveObstacleProblemByProjectedGradientSolver(const MatrixType& mat, Vector typedef std::vector<BoxConstraint<double, blockSize> > BoxConstraintVector; BoxConstraintVector boxConstraints(rhs.size()); for (size_t i = 0; i < boxConstraints.size(); ++i) - { for (size_t j = 0; j < blockSize; ++j) - { - boxConstraints[i].lower(j) = (ignore[i][j]==true) ? 0 : -1; - boxConstraints[i].upper(j) = (ignore[i][j]==true) ? 0 : 1; - } - } + boxConstraints[i][j] = { + (ignore[i][j]==true) ? 0.0 : -1.0, + (ignore[i][j]==true) ? 0.0 : +1.0 + }; ProjectedGradientStep<MatrixType, VectorType> projGradStep(mat, x, rhs); projGradStep.obstacles_ = &boxConstraints; diff --git a/dune/solvers/test/quadraticipoptsolvertest.cc b/dune/solvers/test/quadraticipoptsolvertest.cc index e5f19898ed9fa6cf242c9336c6a8ca80db4bff7d..7024362aed532429621e4a9a3e3ec52a4a9b7394 100644 --- a/dune/solvers/test/quadraticipoptsolvertest.cc +++ b/dune/solvers/test/quadraticipoptsolvertest.cc @@ -35,13 +35,8 @@ void solveObstacleProblemByQuadraticIPOptSolver(const GridType& grid, const Matr // create double obstacle constraints std::vector<BoxConstraint<typename VectorType::field_type,blockSize> > boxConstraints(rhs.size()); for (size_t i = 0; i < boxConstraints.size(); ++i) - { for (int j = 0; j < blockSize; ++j) - { - boxConstraints[i].lower(j) = -1; - boxConstraints[i].upper(j) = +1; - } - } + boxConstraints[i][j] = { -1, +1 }; // create solver Solver solver(mat,x,rhs, NumProc::REDUCED);