Skip to content

IterationStep getSol() superfluous or wrong

IterationStep provides a method getSol() that currently returns a VectorType. IMHO this is not in accordance with the associated comment ("return solution object") or superfluous as the solution (VectorType* x_) is public anyway. Most(all?) IterationSteps simply implement return *(this->x_);.

I am not sure what was the original incentive for this method.

Maybe x_ should be private (or protected) instead? Then a default implementation for getSol() would improve readability IMHO. Maybe an actual solution object was intented in addition and it never has been implemented?