From 0bf1064ac598f6dbdabe766aeafe2d9476545d13 Mon Sep 17 00:00:00 2001
From: Elias Pipping <elias.pipping@fu-berlin.de>
Date: Mon, 19 Dec 2011 14:19:22 +0100
Subject: [PATCH] We have the correct coordinate system
---
dune/tectonic/globalnonlinearity.hh | 1 -
dune/tectonic/localnonlinearity.hh | 1 -
src/TODO.org | 1 -
3 files changed, 3 deletions(-)
diff --git a/dune/tectonic/globalnonlinearity.hh b/dune/tectonic/globalnonlinearity.hh
index 631c6913..260982a2 100644
--- a/dune/tectonic/globalnonlinearity.hh
+++ b/dune/tectonic/globalnonlinearity.hh
@@ -53,7 +53,6 @@ class GlobalNonlinearity {
for (size_t i = 0; i < u.size(); ++i) {
Interval<double> D;
auto const res = restriction(i);
- // TODO: is the coordinate system the right one here?
res->directionalSubDiff(u[i], v[i], D);
subdifferential[0] += D[0];
subdifferential[1] += D[1];
diff --git a/dune/tectonic/localnonlinearity.hh b/dune/tectonic/localnonlinearity.hh
index 4ba501e3..75eb2cd4 100644
--- a/dune/tectonic/localnonlinearity.hh
+++ b/dune/tectonic/localnonlinearity.hh
@@ -43,7 +43,6 @@ template <int dimension> class LocalNonlinearity {
}
double const un = u.two_norm();
double const ndotp = (u * v) / un;
- // Our coordinate system is now such that v is a unit vector!
if (ndotp > 0) {
D[1] = ndotp * func_->rightDifferential(un);
D[0] = ndotp * func_->leftDifferential(un);
diff --git a/src/TODO.org b/src/TODO.org
index 776476a6..5e66a10c 100644
--- a/src/TODO.org
+++ b/src/TODO.org
@@ -1,4 +1,3 @@
* check if v should be normalised by default
-* the subdifferentials for the nonlinearity are probably taken w.r.t a different coordinate system
* use nested iteration to obtain better iteration to start with
* fix up octave bindings (low-pri)
--
GitLab