From 9f5458f6d497031069c1b4d0db2b5f62df64ddd2 Mon Sep 17 00:00:00 2001
From: Eike Cochu <eike@cochu.com>
Date: Sun, 6 Mar 2016 20:55:29 +0100
Subject: [PATCH] cleanup, fixed readme markup
---
README.md | 3 +++
vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java | 4 ++--
vipra-util/src/main/java/de/vipra/util/ArrayUtils.java | 6 +++---
vipra-util/src/main/java/de/vipra/util/model/Sequence.java | 2 +-
4 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/README.md b/README.md
index 29427d19..8b240de6 100644
--- a/README.md
+++ b/README.md
@@ -85,14 +85,17 @@ The following steps were reproduced in that order on a fully updated Ubuntu 15.1
### Troubleshooting
* On running maven: `Failed to read artifact descriptor for org.apache.maven.plugins:maven-resources-plugin:jar:2.3`
+
```bash
sudo /var/lib/dpkg/info/ca-certificates-java.postinst configure
```
* On running `npm install`
+
```bash
sudo chown vipra.vipra -R ~/.npm
```
* On running `bower install` with the error message `/usr/bin/env: node: No such file or directory`
+
```bash
sudo ln -s /usr/bin/nodejs /usr/bin/node
```
diff --git a/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java b/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java
index 17bca671..7011d94b 100644
--- a/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java
+++ b/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java
@@ -262,8 +262,8 @@ public class DTMAnalyzer extends Analyzer {
int idxArticle = 0;
for (final String articleId : index) {
- double[] topicDistribution = topicDistributions[idxArticle++];
- double topicDistributionSum = ArrayUtils.sum(topicDistribution);
+ final double[] topicDistribution = topicDistributions[idxArticle++];
+ final double topicDistributionSum = ArrayUtils.sum(topicDistribution);
// create topic references
final List<TopicRef> newTopicRefs = new ArrayList<>(Constants.K_TOPICS);
diff --git a/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java b/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java
index 971bcfb2..b72fa206 100644
--- a/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java
+++ b/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java
@@ -37,10 +37,10 @@ public class ArrayUtils {
return maximum;
}
- public static double sum(double[] values) {
+ public static double sum(final double[] values) {
double result = 0;
- for (int i = 0; i < values.length; i++)
- result += values[i];
+ for (final double value : values)
+ result += value;
return result;
}
diff --git a/vipra-util/src/main/java/de/vipra/util/model/Sequence.java b/vipra-util/src/main/java/de/vipra/util/model/Sequence.java
index d81ad458..8ca43584 100644
--- a/vipra-util/src/main/java/de/vipra/util/model/Sequence.java
+++ b/vipra-util/src/main/java/de/vipra/util/model/Sequence.java
@@ -46,7 +46,7 @@ public class Sequence implements Comparable<Sequence>, Serializable {
return relevance;
}
- public void setRelevance(Double relevance) {
+ public void setRelevance(final Double relevance) {
this.relevance = relevance;
}
--
GitLab