From c802eb0949677d1c3bccdb41c9263d36b316514a Mon Sep 17 00:00:00 2001 From: Eike Cochu <eike@cochu.com> Date: Fri, 11 Mar 2016 14:47:38 +0100 Subject: [PATCH] cleanup --- .../src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java | 8 ++++---- vipra-util/src/main/java/de/vipra/util/ArrayUtils.java | 10 +++++----- .../src/main/java/de/vipra/util/model/ArticleFull.java | 2 +- .../main/java/de/vipra/util/model/SimilarArticle.java | 6 +++--- .../src/main/java/de/vipra/util/model/TopicFull.java | 6 +++--- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java b/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java index d1060a8f..fc9aa575 100644 --- a/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java +++ b/vipra-cmd/src/main/java/de/vipra/cmd/lda/DTMAnalyzer.java @@ -312,7 +312,7 @@ public class DTMAnalyzer extends Analyzer { double risingDecayRelevance = 0; prevRelevance = relevances[0]; for (int idxSeq2 = 1; idxSeq2 < relevances.length; idxSeq2++) { - double relevanceDiff = relevances[idxSeq2] - prevRelevance; + final double relevanceDiff = relevances[idxSeq2] - prevRelevance; if (relevanceDiff > 0) { risingRelevance += relevanceDiff; } else { @@ -365,18 +365,18 @@ public class DTMAnalyzer extends Analyzer { // calculate divergences - List<SimilarArticle> similarArticles = new ArrayList<>(articlesCount - 1); + final List<SimilarArticle> similarArticles = new ArrayList<>(articlesCount - 1); for (int idxArticle2 = 0; idxArticle2 < articlesCount; idxArticle2++) { if (idxArticle == idxArticle2) continue; - double divergence = ArrayUtils.jsDivergence(topicDistributions[idxArticle], + final double divergence = ArrayUtils.jsDivergence(topicDistributions[idxArticle], topicDistributions[idxArticle2]); if (divergence > Constants.MAX_DIVERGENCE) continue; - SimilarArticle similarArticle = new SimilarArticle(); + final SimilarArticle similarArticle = new SimilarArticle(); similarArticle.setArticle(new Article(MongoUtils.objectId(idindex.get(idxArticle2)))); similarArticle.setDivergence(divergence); similarArticles.add(similarArticle); diff --git a/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java b/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java index 8f2db914..e977f3f7 100644 --- a/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java +++ b/vipra-util/src/main/java/de/vipra/util/ArrayUtils.java @@ -19,16 +19,16 @@ public class ArrayUtils { /** * Jensen Shannon Divergence to measure similarity between two probability * distributions. - * + * * @param p1 * left distribution * @param p2 * right distribution * @return divergence */ - public static double jsDivergence(double[] p1, double[] p2) { + public static double jsDivergence(final double[] p1, final double[] p2) { assert p1.length == p2.length; - double[] avg = new double[p1.length]; + final double[] avg = new double[p1.length]; for (int i = 0; i < p1.length; i++) avg[i] = (p1[i] + p2[i]) / 2.0; return (klDivergence(p1, avg) + klDivergence(p2, avg)) / 2.0; @@ -37,14 +37,14 @@ public class ArrayUtils { /** * Kullback Leibler Divergence to measure similarity between two probability * distributions. - * + * * @param p1 * left distribution * @param p2 * right distribution * @return divergence */ - public static double klDivergence(double[] p1, double[] p2) { + public static double klDivergence(final double[] p1, final double[] p2) { assert p1.length == p2.length; double result = 0; for (int i = 0; i < p1.length; i++) { diff --git a/vipra-util/src/main/java/de/vipra/util/model/ArticleFull.java b/vipra-util/src/main/java/de/vipra/util/model/ArticleFull.java index cac03109..fbad9e2a 100644 --- a/vipra-util/src/main/java/de/vipra/util/model/ArticleFull.java +++ b/vipra-util/src/main/java/de/vipra/util/model/ArticleFull.java @@ -169,7 +169,7 @@ public class ArticleFull extends FileModel<ObjectId> implements Serializable { return similarArticles; } - public void setSimilarArticles(List<SimilarArticle> similarArticles) { + public void setSimilarArticles(final List<SimilarArticle> similarArticles) { this.similarArticles = similarArticles; } diff --git a/vipra-util/src/main/java/de/vipra/util/model/SimilarArticle.java b/vipra-util/src/main/java/de/vipra/util/model/SimilarArticle.java index 86fc4560..3f975ff8 100644 --- a/vipra-util/src/main/java/de/vipra/util/model/SimilarArticle.java +++ b/vipra-util/src/main/java/de/vipra/util/model/SimilarArticle.java @@ -18,7 +18,7 @@ public class SimilarArticle implements Comparable<SimilarArticle>, Serializable return article; } - public void setArticle(Article article) { + public void setArticle(final Article article) { this.article = article; } @@ -26,12 +26,12 @@ public class SimilarArticle implements Comparable<SimilarArticle>, Serializable return divergence; } - public void setDivergence(double divergence) { + public void setDivergence(final double divergence) { this.divergence = divergence; } @Override - public int compareTo(SimilarArticle o) { + public int compareTo(final SimilarArticle o) { return Double.compare(divergence, o.getDivergence()); } diff --git a/vipra-util/src/main/java/de/vipra/util/model/TopicFull.java b/vipra-util/src/main/java/de/vipra/util/model/TopicFull.java index 2589c49b..b8046d97 100644 --- a/vipra-util/src/main/java/de/vipra/util/model/TopicFull.java +++ b/vipra-util/src/main/java/de/vipra/util/model/TopicFull.java @@ -98,7 +98,7 @@ public class TopicFull implements Model<ObjectId>, Serializable { return risingRelevance; } - public void setRisingRelevance(Double risingRelevance) { + public void setRisingRelevance(final Double risingRelevance) { this.risingRelevance = risingRelevance; } @@ -106,7 +106,7 @@ public class TopicFull implements Model<ObjectId>, Serializable { return fallingRelevance; } - public void setFallingRelevance(Double fallingRelevance) { + public void setFallingRelevance(final Double fallingRelevance) { this.fallingRelevance = fallingRelevance; } @@ -114,7 +114,7 @@ public class TopicFull implements Model<ObjectId>, Serializable { return risingDecayRelevance; } - public void setRisingDecayRelevance(Double risingDecayRelevance) { + public void setRisingDecayRelevance(final Double risingDecayRelevance) { this.risingDecayRelevance = risingDecayRelevance; } -- GitLab