From b3ffc745fea09622e5eb36fb8db896a896f03bcd Mon Sep 17 00:00:00 2001 From: Tom <tom.meyer@fu-berlin.de> Date: Thu, 28 Mar 2019 12:48:23 +0100 Subject: [PATCH] todo: check overflow perf --- kernel/sched/pb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/sched/pb.c b/kernel/sched/pb.c index 6117dba5aaae..7bc86a9a7099 100644 --- a/kernel/sched/pb.c +++ b/kernel/sched/pb.c @@ -118,9 +118,11 @@ static struct task_struct * pick_next_task_pb(struct rq *rq, printk(KERN_WARNING "PB TASK %llu RAN %llu INSTRUCTIONS TOO SHORT\n", pb->plan[pb->c_entry].task_id, under_time); } else if (perf_counter > pb->plan[pb->c_entry].n_instr) { - u64 under_time = perf_counter - pb->plan[pb->c_entry].n_instr; + //TODO: Check if actually an overflow occurs and an another calculation is necessary + // (setting a flag in the perf overflow_handler could be a solution) + u64 over_time = perf_counter - pb->plan[pb->c_entry].n_instr; - printk(KERN_WARNING "PB TASK %llu RAN %llu INSTRUCTIONS TOO LONG\n", pb->plan[pb->c_entry].task_id, under_time); + printk(KERN_WARNING "PB TASK %llu RAN %llu INSTRUCTIONS TOO LONG\n", pb->plan[pb->c_entry].task_id, over_time); } pb->c_entry++; -- GitLab