From d301e687c8c5f4be2b3e8fe77210c746e09660c8 Mon Sep 17 00:00:00 2001
From: Jeff Squyres <jsquyres@cisco.com>
Date: Thu, 29 Apr 2021 14:16:45 -0700
Subject: [PATCH] coll_ftagree_earlyreturning.c: temporarily remove dead code
being deleted because, per discussion between @bosilca and @jsquyres
on 29 Apr 2021, @bosilca is pretty sure that this code *should* be
being invoked from somewhere -- otherwise, we likely have a leak in
MPI_FINALIZE. His team is looking into it.
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
---
ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c b/ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c
index 99d8b5fa23..6537bb9bc7 100644
--- a/ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c
+++ b/ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c
@@ -3332,6 +3332,11 @@ int mca_coll_ftagree_iera_intra(void *contrib,
return OMPI_SUCCESS;
}
+#if 0
+// Per @bosilca and @jsquyres discussion 29 Apr 2021: there is
+// probably a memory leak in MPI_FINALIZE right now, because this
+// function does not appear to be being called from anywhere.
+// @bosilca's team is looking into it.
int mca_coll_ftagree_era_free_comm(ompi_communicator_t* comm,
mca_coll_base_module_t *module)
{
@@ -3369,3 +3374,4 @@ int mca_coll_ftagree_era_free_comm(ompi_communicator_t* comm,
return OMPI_SUCCESS;
}
+#endif
--
GitLab