From e838356f3bd67baacf9ec6df7b06c4f88ad90903 Mon Sep 17 00:00:00 2001
From: Guillaume Endignoux <guillaumee@google.com>
Date: Tue, 28 Apr 2020 18:00:36 +0200
Subject: [PATCH] Revert review suggestion.
No, we don't want to run: Command '['rustup', '-', '-', 'v', 'e', 'r', 'b', 'o', 's', 'e', 'install', 'nightly-2020-02-03']'
---
deploy.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/deploy.py b/deploy.py
index 077a385..b8ba61c 100755
--- a/deploy.py
+++ b/deploy.py
@@ -310,13 +310,13 @@ class OpenSKInstaller:
# Need to update
rustup_install = ["rustup"]
if self.args.verbose_build:
- rustup_install.extend("--verbose")
+ rustup_install.extend(["--verbose"])
rustup_install.extend(["install", target_toolchain_fullstring])
self.checked_command(rustup_install)
rustup_target = ["rustup"]
if self.args.verbose_build:
- rustup_target.extend("--verbose")
+ rustup_target.extend(["--verbose"])
rustup_target.extend(
["target", "add", SUPPORTED_BOARDS[self.args.board].arch])
self.checked_command(rustup_target)
@@ -368,7 +368,7 @@ class OpenSKInstaller:
if is_example:
command.extend(["--example", self.args.application])
if self.args.verbose_build:
- command.extend("--verbose")
+ command.extend(["--verbose"])
self.checked_command(command, env=env)
app_path = os.path.join("target", props.arch, "release")
if is_example:
@@ -406,7 +406,7 @@ class OpenSKInstaller:
"elf2tab", package_parameter, self.args.application, "-o", tab_filename
]
if self.args.verbose_build:
- elf2tab_args.extend("--verbose")
+ elf2tab_args.extend(["--verbose"])
for arch, app_file in binaries.items():
dest_file = os.path.join(self.tab_folder, "{}.elf".format(arch))
shutil.copyfile(app_file, dest_file)
--
GitLab