From 2324ce7534cdee1a32fc46a1c792d929125ba2be Mon Sep 17 00:00:00 2001
From: Elias Pipping <elias.pipping@fu-berlin.de>
Date: Fri, 16 Mar 2012 14:01:46 +0100
Subject: [PATCH] FIXMEs/TODOs for the Laursen nonlinearity

---
 dune/tectonic/globallaursennonlinearity.hh | 6 +-----
 src/assemblers.cc                          | 2 ++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/dune/tectonic/globallaursennonlinearity.hh b/dune/tectonic/globallaursennonlinearity.hh
index 1dfc6775..932c6152 100644
--- a/dune/tectonic/globallaursennonlinearity.hh
+++ b/dune/tectonic/globallaursennonlinearity.hh
@@ -43,11 +43,7 @@ class GlobalLaursenNonlinearity
 
     sigma_n [(1/eta \bar Gamma)* + mu id]
 
-    TODO: We chose Gamma = id, so that (\bar Gamma)* = \Gamma^{-1}
-    = id^{-1} = id. The factor 1/eta cancels in this special case, leaving us
-    with
-
-    sigma_n [id + mu id] = sigma_n (1 + mu) id
+    TODO: We currently assume eta = 1
   */
   virtual shared_ptr<LocalNonlinearity<dim> const> restriction(int i) const {
     if ((*nodalIntegrals)[i] == 0)
diff --git a/src/assemblers.cc b/src/assemblers.cc
index 383279bb..df8cffe1 100644
--- a/src/assemblers.cc
+++ b/src/assemblers.cc
@@ -88,6 +88,8 @@ assemble_nonlinearity(
   } else if (friction_model == std::string("Laursen")) {
     return
         // TODO: take state and h into account
+        // FIXME: We should be using a quadratic rather than a linear function
+        // here!
         Dune::make_shared<
             Dune::GlobalLaursenNonlinearity<Dune::LinearFunction, VectorType,
                                             MatrixType> const>(mu, normalStress,
-- 
GitLab