diff --git a/sonarReview/src/main/scala/IssuesParser.scala b/sonarReview/src/main/scala/IssuesParser.scala index 8d6cbe7fcaa7a264c61aefca0bfab341d93e1f79..e4177a956860e11553fefbc6e0b5a91d550da001 100644 --- a/sonarReview/src/main/scala/IssuesParser.scala +++ b/sonarReview/src/main/scala/IssuesParser.scala @@ -58,10 +58,12 @@ class IssuesParser(repo: GitRepo, config: Config) extends LazyLogging { val comments = merged(resourceReports.get map commentsPerResource) + val projectTitle = config.getString(s"projects.$project.projectTitle") + if (comments == JNothing) - ("message" -> s"Congratulations, QA found no issues whatsoever!") + ("message" -> s"Congratulations, QA found no issues whatsoever in $projectTitle!") else - ("message" -> s"Please review your QA analysis results") ~ + ("message" -> s"Please review your QA analysis results for $projectTitle") ~ ("comments" -> comments) } diff --git a/sonarReview/src/test/scala/ParserTest.scala b/sonarReview/src/test/scala/ParserTest.scala index 730d8ed8f9c68e15b59d0616924ac1afa057946a..20c6f7033fef835a8154c752df21d6eca41fe59e 100644 --- a/sonarReview/src/test/scala/ParserTest.scala +++ b/sonarReview/src/test/scala/ParserTest.scala @@ -35,6 +35,7 @@ object ParserTest extends Specification with Mockito { val mockConfig = mock[Config] mockConfig.getString(s"projects.$project.issueReports") returns pathToReports + mockConfig.getString(s"projects.$project.projectTitle") returns "Saros Core" val issuesParser = new IssuesParser(mockRepo, mockConfig) @@ -46,12 +47,12 @@ object ParserTest extends Specification with Mockito { "produce a confirmatory review message when no issues are found" in { val review = issuesParser.parse(changeId, project) - compact(render(parse(review) \ "message")) mustEqual "\"Congratulations, QA found no issues whatsoever!\"" + compact(render(parse(review) \ "message")) mustEqual "\"Congratulations, QA found no issues whatsoever in Saros Core!\"" } "produce a review message that prompts to review the issues found" in { val review = issuesParser.parse(changeId, project) - compact(render(parse(review) \ "message")) mustEqual "\"Please review your QA analysis results\"" + compact(render(parse(review) \ "message")) mustEqual "\"Please review your QA analysis results for Saros Core\"" } "produce a comment for each line with an issue" in { @@ -62,7 +63,7 @@ object ParserTest extends Specification with Mockito { } "produce comments when issues are found" in { - val lengthOfReview = 1942 + val lengthOfReview = 1957 val review = issuesParser.parse(changeId, project) compact(render(parse(review))).length mustEqual lengthOfReview }