From 832ffc1c9733763adf9c503c92b063155c043e5f Mon Sep 17 00:00:00 2001
From: borzechof99 <borzechof99@mi.fu-berlin.de>
Date: Fri, 25 Jun 2021 15:34:22 +0200
Subject: [PATCH] Use get_rating for Sport-Criterion connection in Serializer
---
unisportomat/quiz/serializers.py | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/unisportomat/quiz/serializers.py b/unisportomat/quiz/serializers.py
index d33c5f7..90c71f7 100644
--- a/unisportomat/quiz/serializers.py
+++ b/unisportomat/quiz/serializers.py
@@ -70,11 +70,7 @@ class SingleSportSerializer(serializers.BaseSerializer):
criterion_data["pk"] = criterion.pk
criterion_data["name"] = criterion.name
- # The iterator iterates over the Criterions connected, and not the criterion connection itself, so we need to get that one again
- # TODO: Use get_rating of the Sport object
- criterion_data["value"] = CriterionRating.objects.get(
- criterion=criterion.pk, sport=sport.pk
- ).rating
+ criterion_data["value"] = sport.get_rating(criterion)
criteria.append(criterion_data)
--
GitLab