Setup initial config for Routing service
All threads resolved!
All threads resolved!
Setup of initial Docker and Spring config. Creation of two dummy REST endpoints of the application
Merge request reports
Activity
added 2 commits
Maybe split this MR into several MRs:
- one for the creation of protos
- one for the addition of the algorithm (it will be nice, if you could add comments on what is changed by you, so that we can look into the specific place, as there is no point in validating the library)
- one for the setup of the whole repository
- one for the docker-compose.yml
It is really hard in general for a person to review 40+ files. In general it is a good approach to create a single purpose MRs, as it is easier for a reviewer to get through the code and understand what you did. As we are all expected to work on all parts of the code, it will be nice, that all of us know how it works and this can be achieved exactly through reviewing MRs. But, when there are 40+ changes for a MR doing (as stated above) 4 things simultaneously, this is not the case. It is not meant in any bad manner :)
Edited by kralevaadded 2 commits
added 3 commits
-
22a06298...5c711725 - 2 commits from branch
main - 6fd22079 - Merge branch 'main' into develop
-
22a06298...5c711725 - 2 commits from branch
mentioned in commit 9eeb2084
Please register or sign in to reply