Skip to content
Snippets Groups Projects

Replace local energies by local densities

  • wrap the densities by a generic IntegralEnergy
  • this preserves all material properties
  • reduces redundant code
Edited by Patrick Jaap

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • oliver.sander_at_tu-dresden.de
  • oliver.sander_at_tu-dresden.de
  • Nice, thanks! However, I am tempted to say that all these new density classes should have their own files. Because some day we will remove those deprecated energy classes, and then it'll be weird to have 'density' classes in 'energy.hh' files. Better do it now.

  • Patrick Jaap resolved all threads

    resolved all threads

  • Patrick Jaap added 1 commit

    added 1 commit

    • 351b505f - Replace local energies by local densities

    Compare with previous version

  • Thank you! I hate to say this, but I have one more round of wishes...

    • Standard Dune indentation is two spaces per indentation level. Please use that for new files.
    • Let's call the classes and files FooBarDensity (foobardensity.hh) rather than FooBarEnergyDensity (foobarenergydensity.hh). The names are long enough already.
    • A changelog entry
    • You need to add the new files to CmakeLists.txt
  • Patrick Jaap added 1 commit

    added 1 commit

    • e8295a6e - Replace local energies by local densities

    Compare with previous version

  • Patrick Jaap added 1 commit

    added 1 commit

    • eef89556 - Replace local energies by local densities

    Compare with previous version

  • @oliver.sander_at_tu-dresden.de MR updated fulfilling your wishes :)

  • Patrick Jaap added 1 commit

    added 1 commit

    • a7e5a266 - Replace local energies by local densities

    Compare with previous version

  • edit: forgot two files in CMakeLists.txt

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading