Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
dune-solvers
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
agnumpde
dune-solvers
Commits
2205a903
Commit
2205a903
authored
12 years ago
by
Uli Sack
Committed by
usack
12 years ago
Browse files
Options
Downloads
Patches
Plain Diff
add task about SolverResult; collect all MultigridStep related todos
[[Imported from SVN: r7353]]
parent
b4715e98
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
TODO
+7
-5
7 additions, 5 deletions
TODO
with
7 additions
and
5 deletions
TODO
+
7
−
5
View file @
2205a903
...
@@ -37,19 +37,19 @@ and maintain.
...
@@ -37,19 +37,19 @@ and maintain.
* Implement (P)CG as IterationStep for the LoopSolver
* Implement (P)CG as IterationStep for the LoopSolver
* Make all public member variables protected and introduce public methods for access.
* Make all public member variables protected and introduce public methods for access.
* Use references instead of pointers as member function arguments.
* Use references instead of pointers as member function arguments.
* Move stuff done in MultigridStep::setNumberOfLevels() into preprocess().
* Make handling solution vector in IterationStep consistent:
* Make handling solution vector in IterationStep consistent:
Either provide a const reference, store a copy and give (reference)
Either provide a const reference, store a copy and give (reference)
access to this copy using getSol() or provide a (non
s
onst) reference,
access to this copy using getSol() or provide a (non
c
onst) reference,
store the solution there and make getSol() return this reference
store the solution there and make getSol() return this reference
and no copy.
and no copy.
(C: I'd prefer the latter to reduce the number of vector copies).
(C: I'd prefer the latter to reduce the number of vector copies).
* Make setting up a MultigridStep easier. E.g. by providing a default
* Move stuff done in MultigridStep::setNumberOfLevels() into preprocess().
version that is preconfigured with GS smoother and coarse grid solver.
* Remove MultigridStep::setNumberOfLevels(), this number is already
* Remove MultigridStep::setNumberOfLevels(), this number is already
fixed by the size of the transfer operator vector.
fixed by the size of the transfer operator vector.
* MultigridStep hides member names from the base class by reusing
* MultigridStep hides member names from the base class by reusing
them for different things
them for different things
* Make setting up a MultigridStep easier. E.g. by providing a default
version that is preconfigured with GS smoother and coarse grid solver.
* MultigridStep works differently on the finest and the other
* MultigridStep works differently on the finest and the other
levels. On the finest, the smoother is used with the rhs of
levels. On the finest, the smoother is used with the rhs of
the linear system and the current iterate as initial value
the linear system and the current iterate as initial value
...
@@ -60,7 +60,9 @@ and maintain.
...
@@ -60,7 +60,9 @@ and maintain.
Computing corrections also on the finest level might allow
Computing corrections also on the finest level might allow
to solve systems really up to machine accuracy sice you
to solve systems really up to machine accuracy sice you
have more digits for the correction.
have more digits for the correction.
* devise a coherent meaningful concept of a SolverResult struct for the various
Solver Base-classes (Solver, IterativeSolver, LoopSolver atl) and substitute the
q&d version implemented now
## Naming of classes and members
## Naming of classes and members
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment