Skip to content
Snippets Groups Projects
Commit b93c3ada authored by Max Kahnt's avatar Max Kahnt
Browse files

Reorder template parameters to allow for a default BitVector type. 

This addresses issue #10.
parent 36d177a6
Branches
Tags
Hide whitespace changes
Inline Side-by-side
  • pipping @pipping ·
    Contributor

    Hm. I greatly appreciate the changes you've made here towards default-constructibility. This particular change here seems like it should have been discussed before, though. E.g. dune-tnnmg-examples!1 is now invalid. I don't know if anyone was already using BlockGSStep outside of dune-solvers. But given that we deprecated the TruncatedBlockGSStep and suggested this as a replacement, I wouldn't be surprised if a few people were...

  • pipping @pipping ·
    Contributor

    If it turns out that nobody was using this class outside of dune-solvers yet, it might make sense to either

    • push these changes to the 2.5 branch as well or
    • remove blockgssteps.hh from the 2.5 branch retroactively entirely again

    so that we don't have one interface in 2.5 and the other in post-2.5.

    Edited by pipping
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment