Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
dune-solvers
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
agnumpde
dune-solvers
Commits
c01388ef
Commit
c01388ef
authored
13 years ago
by
graeser
Committed by
graeser
13 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Add todo list
[[Imported from SVN: r5909]]
parent
4998d932
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
TODO
+56
-0
56 additions, 0 deletions
TODO
with
56 additions
and
0 deletions
TODO
0 → 100644
+
56
−
0
View file @
c01388ef
# Bugs
* ProjectedBlockGSStep does nothing for a whole block if there are
zero diagonal entries in the diagonal block.
One would expect that it solves the system for the reduced
block containing the block rows with nonzero diagonal entry
in this case.
* MultigridStep is not robust wrt setup order.
# Performance issues
* BlockGSStep and the derived classes loop over each row twice.
Once for computing the residual, once for finding the diagonal entry.
This could be done in one loop.
* The ProjectedBlockGSStep 'solves' the local obstacle problems
by a local projected GS with a fixed number of 20 iteration steps.
For scalar valued problems one would be enough. Even for vector valued
problems one might still be OK but much cheaper. (Does this have any
performance impact on linear elasticity problems?)
# Design issues
* Implement (P)CG as IterationStep for the LoopSolver
* Make all public member variables protected and introduce public methods for access.
* Use references instead of pointers as member function arguments.
* Move stuff done in MultigridStep::setNumberOfLevels() into preprocess().
* Make handling solution vector in IterationStep consistent:
Either provide a const reference, store a copy and give (reference)
access to this copy using getSol() or provide a (nonsonst) reference,
store the solution there and make getSol() return this reference
and no copy.
(C: I'd prefer the latter to reduce the number of vector copies).
* Make setting up a MultigridStep easier. E.g. by providing a default
version that is preconfigured with GS smoother and coarse grid solver.
* Remove MultigridStep::setNumberOfLevels(), this number is already
fixed by the size of the transfer operator vector.
# Naming of classes and members
* ignoreNodes_ should be called ignore_/ignoreIndices_/ignoreComponents_
# Missing features
* Transfer operator assembler for adaptively refined grids (without refinementtype=copy)
This is already implemented in dune-fufem. It could be moved here if the
dependency on P1NodalBasis is removed.
* Nested iteration for ObstacleTNNMGStep.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment