Implementations for geometryInInside() and geometryInOutside()

This implements said methods geometryInInside() and geometryInOutside() for SubgridLeafIntersections. While the concept of creating new geometries via Dune::MultilinearGeometry where needed was rather straight-forward, the actual implementation took quite a bit of work due to the different types. @akbib and @maxka came up with using C++17's std::variant and @akbib did the work implementing this. I contributed a fallback implementation of std::variant that does not need C++17.

assigned to @graeser

added 1 commit

• cda36334 - [bugfix] add explicit cast

Compare with previous version

added 1 commit

• cd2ccaf8 - [bugfix] add explicit cast

Compare with previous version

Is the std::variant implementation already in dune-common? If not I would just merge this request and then switch to the dune-comon Std::variant once it is in there

No, people seem to have lost interest quickly (I can't blame anyone, reviewing this kind of rather low-level code is a pain). However, I've used the code from this MR since it was opened and did not encounter any problems, so I'd vote for merging it.

Well, I remember I updated a thing or two for the variant implementation while preparing the MR in dune-common. Give me a moment to check if there are relevant changes that should be here, too.

Would you also like to have it in the 2.6 release of dune-subgrid?

Technically, one could argue that something that is hardly tested in the field does not really qualify for a stable release. On the other hand, this feature is quite nice to have, I'd say.

For the Std::variant thing, I slightly improved the implementation for the dune-common MR. I will integrate these changes here, too.

added 1 commit

• 0ba9d5ba - Update Std::variant implementation

Compare with previous version

added 1 commit

• 5a2275a3 - Use the variant impl from subgrid

Compare with previous version

added 2 commits

• f8a0dbcd - Add std::variant fallback
• ceaf95c1 - Add implementation for geometryInInside and geometryInOutside

Compare with previous version

I committed the updates and rebased. Once the pipeline passes this can be merged in my opinion.

merged

mentioned in commit 5923a229

Thanks a lot to all involved in implementing and testing this!