Skip to content
Snippets Groups Projects
Unverified Commit 16438854 authored by Jeff Squyres's avatar Jeff Squyres Committed by GitHub
Browse files

Merge pull request #8869 from jsquyres/pr/remind-people-about-bot-notacherrypick

git-commit-checks.py: remind people about bot:notacherrypick
parents 6d901fc8 e5ef9581
No related branches found
No related tags found
No related merge requests found
...@@ -50,6 +50,8 @@ from github import Github ...@@ -50,6 +50,8 @@ from github import Github
GOOD = "good" GOOD = "good"
BAD = "bad" BAD = "bad"
NACP = "bot:notacherrypick"
GITHUB_WORKSPACE = os.environ.get('GITHUB_WORKSPACE') GITHUB_WORKSPACE = os.environ.get('GITHUB_WORKSPACE')
GITHUB_SHA = os.environ.get('GITHUB_SHA') GITHUB_SHA = os.environ.get('GITHUB_SHA')
GITHUB_BASE_REF = os.environ.get('GITHUB_BASE_REF') GITHUB_BASE_REF = os.environ.get('GITHUB_BASE_REF')
...@@ -218,7 +220,7 @@ def check_cherry_pick(config, repo, commit): ...@@ -218,7 +220,7 @@ def check_cherry_pick(config, repo, commit):
else: else:
if config['cherry pick required']: if config['cherry pick required']:
return BAD, "does not include a cherry pick message" return BAD, f"does not include a cherry pick message (did you need to {NACP}?)"
else: else:
return GOOD, None return GOOD, None
...@@ -284,7 +286,7 @@ def check_github_pr_description(config): ...@@ -284,7 +286,7 @@ def check_github_pr_description(config):
pr_num = int(match.group(1)) pr_num = int(match.group(1))
pr = repo.get_pull(pr_num) pr = repo.get_pull(pr_num)
if "bot:notacherrypick" in pr.body: if NACP in pr.body:
config['cherry pick required'] = False config['cherry pick required'] = False
#---------------------------------------------------------------------------- #----------------------------------------------------------------------------
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment