Fix a variety of compiler warnings

- Remove dead code
- Fix shadow variable declarations
- Cast %p arguments to (void*)
- Make integer comparisons agree in sign
- Make a local function static so that it does not require a prior
  declaration

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>