Skip to content
Snippets Groups Projects
Select Git revision
  • risc-v default protected
  • master
2 results
Blame Permalink
  • koenigl's avatar
    e1c6aca7
    button subsystem: use manual panic! instead of unwrap() · e1c6aca7
    koenigl authored 
    unwrap only works if the error value implements Debug, however since the
buttons subsystem doesn't return TockValue<E> but TockError this isn't the case
(anymore).  In theory one should think about refactoring check_user_presence()
to return TockResult<()> and possibly implementing some way for Ctap2StatusCode
to be converted to TockError enums or similar.  Then we can just pass errors
up the stack instead of panicking early.
    e1c6aca7
    History
    button subsystem: use manual panic! instead of unwrap()
    koenigl authored 
    unwrap only works if the error value implements Debug, however since the
buttons subsystem doesn't return TockValue<E> but TockError this isn't the case
(anymore).  In theory one should think about refactoring check_user_presence()
to return TockResult<()> and possibly implementing some way for Ctap2StatusCode
to be converted to TockError enums or similar.  Then we can just pass errors
up the stack instead of panicking early.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.