-
- Downloads
build: move COLO under CONFIG_REPLICATION
We don't allow to use x-colo capability when replication is not configured. So, no reason to build COLO when replication is disabled, it's unusable in this case. Note also that the check in migrate_caps_check() is not the only restriction: some functions in migration/colo.c will just abort if called with not defined CONFIG_REPLICATION, for example: migration_iteration_finish() case MIGRATION_STATUS_COLO: migrate_start_colo_process() colo_process_checkpoint() abort() It could probably make sense to have possibility to enable COLO without REPLICATION, but this requires deeper audit of colo & replication code, which may be done later if needed. Signed-off-by:Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Acked-by:
Dr. David Alan Gilbert <dave@treblig.org> Reviewed-by:
Juan Quintela <quintela@redhat.com> Message-Id: <20230428194928.1426370-4-vsementsov@yandex-team.ru> Signed-off-by:
Juan Quintela <quintela@redhat.com>
Showing
- hmp-commands.hx 2 additions, 0 deletionshmp-commands.hx
- migration/colo.c 0 additions, 28 deletionsmigration/colo.c
- migration/meson.build 4 additions, 2 deletionsmigration/meson.build
- migration/migration-hmp-cmds.c 2 additions, 0 deletionsmigration/migration-hmp-cmds.c
- migration/migration.c 6 additions, 0 deletionsmigration/migration.c
- qapi/migration.json 6 additions, 3 deletionsqapi/migration.json
- stubs/colo.c 39 additions, 0 deletionsstubs/colo.c
- stubs/meson.build 1 addition, 0 deletionsstubs/meson.build
Loading
Please register or sign in to comment