Fix Tests and Linter

.pylintrc

@@ -13,4 +13,5 @@ disable=line-too-long,
         arguments-renamed,
         too-many-lines,
         too-many-locals,
+        attribute-defined-outside-init
 

unisportomat/quiz/models.py

@@ -369,18 +369,25 @@ class QuestionOrderEntry(models.Model):
 
 
 class SingletonModel(models.Model):
+    """
+    Singleton Model used for Greeting and End Text, so that only one object exists per Model
+    """
+
     class Meta:
         abstract = True
 
     def save(self, *args, **kwargs):
         self.pk = 1
-        super(SingletonModel, self).save(*args, **kwargs)
+        super().save(*args, **kwargs)
 
     def delete(self, *args, **kwargs):
         pass
 
     @classmethod
     def load(cls):
+        """
+        Function for returning the singleton Object
+        """
         obj, _created = cls.objects.get_or_create(pk=1)
         return obj
 

unisportomat/quiz/tests.py

@@ -727,7 +727,7 @@ class APITest(APITestCase):
         Test whether the greeting behaves correctly
         """
 
-        response = self.client.get(reverse("greeting"))
+        response = self.client.get(reverse("greeting-end-detail", kwargs={"pk": 1}))
 
         self.assertEqual(response.data["text_de"], "Willkommen zum Uni-Sport-O-Mat!")
         self.assertEqual(response.data["text_de"], response.data["text_en"])
@@ -736,15 +736,20 @@ class APITest(APITestCase):
 
         data = {"text_de": "Hallo", "text_en": "Hi"}
 
-        response = self.client.post(reverse("greeting"), format="json", data=data)
+        response = self.client.put(
+            reverse("greeting-end-detail", kwargs={"pk": 1}),
+            format="json",
+            data=data,
+        )
 
-        response = self.client.get(reverse("greeting"))
+        response = self.client.get(reverse("greeting-end-detail", kwargs={"pk": 1}))
 
         self.assertEqual(response.data["text_de"], "Hallo")
         self.assertEqual(response.data["text_en"], "Hi")
 
         # If the object is deleted, the default values are returned again
-        response = self.client.delete(reverse("greeting"))
+        response = self.client.delete(reverse("greeting-end-detail", kwargs={"pk": 1}))
+        response = self.client.get(reverse("greeting-end-detail", kwargs={"pk": 1}))
 
         self.assertEqual(response.data["text_de"], "Willkommen zum Uni-Sport-O-Mat!")
         self.assertEqual(response.data["text_de"], response.data["text_en"])
@@ -754,7 +759,7 @@ class APITest(APITestCase):
         Test whether the end behaves correctly
         """
 
-        response = self.client.get(reverse("end"))
+        response = self.client.get(reverse("greeting-end-detail", kwargs={"pk": 2}))
 
         self.assertEqual(response.data["text_de"], "Wähle deinen Sport!")
         self.assertEqual(response.data["text_de"], response.data["text_en"])
@@ -763,15 +768,18 @@ class APITest(APITestCase):
 
         data = {"text_de": "Hallo", "text_en": "Hi"}
 
-        response = self.client.post(reverse("end"), format="json", data=data)
+        response = self.client.put(
+            reverse("greeting-end-detail", kwargs={"pk": 2}), format="json", data=data
+        )
 
-        response = self.client.get(reverse("end"))
+        response = self.client.get(reverse("greeting-end-detail", kwargs={"pk": 2}))
 
         self.assertEqual(response.data["text_de"], "Hallo")
         self.assertEqual(response.data["text_en"], "Hi")
 
         # If the object is deleted, the default values are returned again
-        response = self.client.delete(reverse("end"))
+        response = self.client.delete(reverse("greeting-end-detail", kwargs={"pk": 2}))
+        response = self.client.get(reverse("greeting-end-detail", kwargs={"pk": 2}))
 
         self.assertEqual(response.data["text_de"], "Wähle deinen Sport!")
         self.assertEqual(response.data["text_de"], response.data["text_en"])