Skip to content
Snippets Groups Projects
Commit 1741ca28 authored by Ansgar Burchardt's avatar Ansgar Burchardt
Browse files

move a few more classes into the Dune::Solvers namespace

parent 724aaeaf
No related branches found
No related tags found
No related merge requests found
Pipeline #
Loading
  • Owner

    For me "anything unpleasant" e.g. means any class with public member variables. Theses are very prone for user errors and a real pain to maintain. I strongly support to only move stuff that has been cleaned up and carefully reviewed to the namespace.

  • Owner

    @burchardt_at_igpm.rwth-aachen.de Would you mind if I partially reverted your commit for the discussed reason?

  • Ansgar Burchardt @burchardt_at_igpm.rwth-aachen.de ·
    Author Maintainer

    @maxka: No, I think SolverResult, numproc.hh and solver.hh are only things I use indirectly. So I don't mind where they are.

  • maxka @maxka

    mentioned in commit 16fdcb27

    ·

    mentioned in commit 16fdcb27

    Toggle commit list
  • maxka @maxka

    mentioned in commit 166fa881

    ·

    mentioned in commit 166fa881

    Toggle commit list
  • Owner

    AMGStep exhibits the public member variables SmootherArgs and Criterion and therefore falls into @graeser 's unwanted list. @burchardt_at_igpm.rwth-aachen.de how do you feel about reverting this as well?

    The protected members in EnergyNorm seem to be fine (to me).

    Edited by maxka
  • Developer

    Or how about we make these members private and add setters and getters?

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment